server.js: only build the CSS when CSS changes, not the layouts #2621
+36
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe there are a few cases this won't be perfect, but I think it's better this way because it's a lot faster for development. |
SEWeiTung
approved these changes
Oct 9, 2019
|
@nodejs/website This could use some more reviews. |
aymen94
approved these changes
Oct 10, 2019
This was referenced Jan 12, 2021
This was referenced Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because it requires #2544 merged, but most importantly because there's a bug in chokidar 3.1.1 that globs don't work on Windows so I can't test properly yet.But the idea is that since the CSS is separated completely, we shouldn't rebuild everything when just the CSS changes.