Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: update translation of 'nodejs-docker-webapp.md' #2084

Merged
merged 2 commits into from
Feb 18, 2019

Conversation

yous
Copy link
Contributor

@yous yous commented Feb 16, 2019

Ref #1476, #2080.

You may want to view the whole file because the comments have been updated without the updates of translation.

@nodejs/nodejs-ko Review please.

@yous
Copy link
Contributor Author

yous commented Feb 16, 2019

I can't assign @nodejs/nodejs-ko as reviewers, are there some limitations?

@ghost ghost requested review from outsideris and jbottigliero February 16, 2019 07:30
@yous
Copy link
Contributor Author

yous commented Feb 16, 2019

Actually I’m in the team now, but I’m not available to assign them as reviewers when I make a new PR.

@taggon
Copy link
Contributor

taggon commented Feb 17, 2019

Can we use ‘작업 디렉터리’ instead of ‘워킹 디렉터리’?

@yous
Copy link
Contributor Author

yous commented Feb 18, 2019

Sure, I've updated.

@ghost
Copy link

ghost commented Feb 18, 2019

@taggon:Can you confirm whether it's OK? You can merge it if possible :)

Copy link
Contributor

@taggon taggon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@taggon taggon merged commit d6bc26b into nodejs:master Feb 18, 2019
@yous yous deleted the ko-docker-webapp branch February 18, 2019 15:34
@yous
Copy link
Contributor Author

yous commented Feb 18, 2019

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants