Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make homepage banner translatable #1525

Merged
merged 2 commits into from
Dec 22, 2017
Merged

Make homepage banner translatable #1525

merged 2 commits into from
Dec 22, 2017

Conversation

fhemberger
Copy link
Contributor

Fixes #1524

Copy link
Contributor

@Tiriel Tiriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits (fr translation, non-critical)

@@ -1,6 +1,7 @@
---
layout: index.hbs
labels:
banner: Important security releases, please update now!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it saves a PR, I think we could go with:
"Mises à jour de sécurité importantes, veuillez mettre à jour!"
@nodejs/nodejs-fr Ca me semble redondant. D'autres idées?

@fhemberger
Copy link
Contributor Author

@Tiriel Updated, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants