Release prematurely marked as LTS

[richardlau]

URL:

https://nodejs.org/en

Browser Name:

Edge

Browser Version:

130.0.2849.56 (Official build) (64-bit)

Operating System:

Windows 11 Enterprise Version 22H2 build 22621.4169

How to reproduce the issue:

From earlier today, https://nodejs.org/en was incorrectly advertising Node.js 22.10.0 as Long Term Support (LTS):

This was incorrect -- the first LTS release of Node.js 22 is 22.11.0 (which I've just pushed up in the last couple of hours). I imagine this is some incorrect correlation between the release schedule and current date.

FWIW https://nodejs.org/dist/index.json / https://nodejs.org/dist/index.tab correctly indicate "lts": false for Node.js 22.10.0 and "lts": "Jod" for Node.js 22.11.0.

[AugustinMauroy]

It's an error in logic: we base our calculations on the status, which is calculated from the start and end dates, so the release or not.

[ovflowd]

I believe the root issue is within https://github.com/cutenode/nodevu cc @bnb

[richardlau]

I think @AugustinMauroy is correct, looks like code in this repo which is checking dates, and not the actual release metadata:

nodejs.org/apps/site/next-data/generators/releaseData.mjs

Lines 13 to 15 in 90afad3

	if (ltsStart && now >= new Date(ltsStart)) {
	return 'LTS';
	}

[ovflowd]

I think @AugustinMauroy is correct, looks like code in this repo which is checking dates, and not the actual release metadata:

nodejs.org/apps/site/next-data/generators/releaseData.mjs

Lines 13 to 15 in 90afad3

	if (ltsStart && now >= new Date(ltsStart)) {
	return 'LTS';
	}

Makes sense, and then we get the first item with LTS marked.

So the issue is that this was triggered before 22.11 actually went out but on the day that supposedly is valid, right?

[ovflowd]

Good thing is that since the data gets updated every 10 minutes (I think?), the links are correct already.

[richardlau]

So the issue is that this was triggered before 22.11 actually went out but on the day that supposedly is valid, right?

Correct.

[richardlau]

I believe the root issue is within https://github.com/cutenode/nodevu cc @bnb

There might also be a bug in nodevu as it appears that might also be doing time-based checks, but at least for this repository it would make sense to start with #7153 (comment).

[aduh95]

IMO it makes sense to recommend downloading Node.js 22.x on the day it becomes LTS, most users won't actually care what the metadata says, and it's not like 22.11.0 contained any feature not in 22.10.0.

[RedYetiDev]

The issue is in regards to all future LTS releases, not just 22