Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update repl tests #9991

Closed
wants to merge 1 commit into from
Closed

Conversation

makenova
Copy link
Contributor

@makenova makenova commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

change var to const or let
change assert.equal to assert.strictEqual

change var to const or let
change assert.equal to assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@gibfahn
Copy link
Member

gibfahn commented Dec 2, 2016

@gibfahn
Copy link
Member

gibfahn commented Dec 2, 2016

@makenova Your name is currently set as makenova, people normally use their full name.

If you want to amend the commit you can use

git commit --amend --no-edit --author="Your Name <[email protected]>"

Or if you're not sure how to do that a Collaborator can change it for you while landing.

I recommend changing your name globally with:

git config --global user.name "Your Name"

@makenova
Copy link
Contributor Author

makenova commented Dec 2, 2016

@gibfahn That's intentional.

jasnell pushed a commit that referenced this pull request Dec 5, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in 06306a3. Thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: nodejs#9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: nodejs#9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9991
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants