Use assert.strictEqual instead of assert.equal #9952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
child_process
imyller
added
the
code-and-learn
|
@nitsnwits May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was using. This commit includes changing use of assert.equal to assert.strictEqual.
|
@imyller done! |
|
@nitsnwits Excellent. Thank you 👍 |
cjihrig
approved these changes
Dec 4, 2016
jasnell
approved these changes
Dec 5, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 21, 2016
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: nodejs#9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in fde5042 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
In file /test/parallel/test-cwd-enoent-repl.js at line: 26:3 and 27:3 assert.equal was used. This commit changes use of assert.equal to assert.strictEqual. PR-URL: #9952 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Test
Description of change
convert assert.equal to assert.strictEqual