Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: var to const/let; equal to strictEqual #9944

Closed
wants to merge 1 commit into from
Closed

test: var to const/let; equal to strictEqual #9944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 32 additions & 31 deletions test/parallel/test-fs-append-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
var join = require('path').join;
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const join = require('path').join;

var filename = join(common.tmpDir, 'append.txt');
const filename = join(common.tmpDir, 'append.txt');

var currentFileData = 'ABCD';
const currentFileData = 'ABCD';

var n = 220;
var s = '南越国是前203年至前111年存在于岭南地区的一个国家，国都位于番禺，疆域包括今天中国的广东、' +
'广西两省区的大部份地区，福建省、湖南、贵州、云南的一小部份地区和越南的北部。' +
'南越国是秦朝灭亡后，由南海郡尉赵佗于前203年起兵兼并桂林郡和象郡后建立。' +
'前196年和前179年，南越国曾先后两次名义上臣属于西汉，成为西汉的“外臣”。前112年，' +
'南越国末代君主赵建德与西汉发生战争，被汉武帝于前111年所灭。南越国共存在93年，' +
'历经五代君主。南越国是岭南地区的第一个有记载的政权国家，采用封建制和郡县制并存的制度，' +
'它的建立保证了秦末乱世岭南地区社会秩序的稳定，有效的改善了岭南地区落后的政治、##济现状。\n';
const n = 220;
const s = '南越国是前203年至前111年存在于岭南地区的一个国家，国都位于番禺，疆域包括今天中国的广东、' +
'广西两省区的大部份地区，福建省、湖南、贵州、云南的一小部份地区和越南的北部。' +
'南越国是秦朝灭亡后，由南海郡尉赵佗于前203年起兵兼并桂林郡和象郡后建立。' +
'前196年和前179年，南越国曾先后两次名义上臣属于西汉，成为西汉的“外臣”。前112年，' +
'南越国末代君主赵建德与西汉发生战争，被汉武帝于前111年所灭。南越国共存在93年，' +
'历经五代君主。南越国是岭南地区的第一个有记载的政权国家，采用封建制和郡县制并存的制度，' +
'它的建立保证了秦末乱世岭南地区社会秩序的稳定，有效的改善了岭南地区落后的政治、##济现状。\n';

var ncallbacks = 0;
let ncallbacks = 0;

common.refreshTmpDir();

Expand All @@ -30,12 +30,12 @@ fs.appendFile(filename, s, function(e) {
fs.readFile(filename, function(e, buffer) {
if (e) throw e;
ncallbacks++;
assert.equal(Buffer.byteLength(s), buffer.length);
assert.strictEqual(Buffer.byteLength(s), buffer.length);
});
});

// test that appends data to a non empty file
var filename2 = join(common.tmpDir, 'append2.txt');
const filename2 = join(common.tmpDir, 'append2.txt');
fs.writeFileSync(filename2, currentFileData);

fs.appendFile(filename2, s, function(e) {
Expand All @@ -46,15 +46,16 @@ fs.appendFile(filename2, s, function(e) {
fs.readFile(filename2, function(e, buffer) {
if (e) throw e;
ncallbacks++;
assert.equal(Buffer.byteLength(s) + currentFileData.length, buffer.length);
assert.strictEqual(Buffer.byteLength(s) + currentFileData.length,
buffer.length);
});
});

// test that appendFile accepts buffers
var filename3 = join(common.tmpDir, 'append3.txt');
const filename3 = join(common.tmpDir, 'append3.txt');
fs.writeFileSync(filename3, currentFileData);

var buf = Buffer.from(s, 'utf8');
const buf = Buffer.from(s, 'utf8');

fs.appendFile(filename3, buf, function(e) {
if (e) throw e;
Expand All @@ -64,36 +65,36 @@ fs.appendFile(filename3, buf, function(e) {
fs.readFile(filename3, function(e, buffer) {
if (e) throw e;
ncallbacks++;
assert.equal(buf.length + currentFileData.length, buffer.length);
assert.strictEqual(buf.length + currentFileData.length, buffer.length);
});
});

// test that appendFile accepts numbers.
var filename4 = join(common.tmpDir, 'append4.txt');
const filename4 = join(common.tmpDir, 'append4.txt');
fs.writeFileSync(filename4, currentFileData);

var m = 0o600;
const m = 0o600;
fs.appendFile(filename4, n, { mode: m }, function(e) {
if (e) throw e;

ncallbacks++;

// windows permissions aren't unix
if (!common.isWindows) {
var st = fs.statSync(filename4);
assert.equal(st.mode & 0o700, m);
const st = fs.statSync(filename4);
assert.strictEqual(st.mode & 0o700, m);
}

fs.readFile(filename4, function(e, buffer) {
if (e) throw e;
ncallbacks++;
assert.equal(Buffer.byteLength('' + n) + currentFileData.length,
buffer.length);
assert.strictEqual(Buffer.byteLength('' + n) + currentFileData.length,
buffer.length);
});
});

// test that appendFile accepts file descriptors
var filename5 = join(common.tmpDir, 'append5.txt');
const filename5 = join(common.tmpDir, 'append5.txt');
fs.writeFileSync(filename5, currentFileData);

fs.open(filename5, 'a+', function(e, fd) {
Expand All @@ -115,15 +116,15 @@ fs.open(filename5, 'a+', function(e, fd) {
if (e) throw e;

ncallbacks++;
assert.equal(Buffer.byteLength(s) + currentFileData.length,
buffer.length);
assert.strictEqual(Buffer.byteLength(s) + currentFileData.length,
buffer.length);
});
});
});
});

process.on('exit', function() {
assert.equal(12, ncallbacks);
assert.strictEqual(12, ncallbacks);

fs.unlinkSync(filename);
fs.unlinkSync(filename2);
Expand Down