Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes var to let & const as appropriate #9920

Closed
wants to merge 3 commits into from

Conversation

markmachine
Copy link

Checklist
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

change tests to use assert.strictEqual vs assert.equal

change tests to use assert.strictEqual vs assert.equal
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Dec 1, 2016
@mscdex mscdex added child_process Issues and PRs related to the child_process subsystem. and removed process Issues and PRs related to the process subsystem. labels Dec 1, 2016
Copy link
Contributor

@princejwesley princejwesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit msg with test: prefix

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@markmachine May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

* references closed nodejs#2446
* updates broken documentation link
* fixes copy based on comments from @sam-github

* Android: `"android"`
* Windows/Cygwin: `"win32"`
* Mac OS X: `"darwin"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proper branding here is macOS

@markmachine
Copy link
Author

@imyller my apologies, i meant to make a separate PR. I will fix the problems and start again.

Thanks for your help.

@Trott
Copy link
Member

Trott commented Dec 6, 2016

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 6, 2016

Landed in b074ae2.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: #9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: #9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: #9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* var -> const
* assert.equal() -> assert.strictEqual()

PR-URL: #9920
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants