Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rm console.log in test-vm-static-this.js #9887

Closed
wants to merge 1 commit into from

Conversation

dbradf
Copy link
Contributor

@dbradf dbradf commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

In test/parallel/test-vm-statis-this.js

  • Replace console.error with comments
  • assert.equal -> assert.strictEqual

In test/parallel/test-vm-statis-this.js
* Replace console.error with comments
* assert.equal -> assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

@cjihrig
Copy link
Contributor

cjihrig commented Dec 4, 2016

Landed in 1a324f2. Thanks!

@cjihrig cjihrig closed this Dec 4, 2016
cjihrig pushed a commit that referenced this pull request Dec 4, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: nodejs#9887
Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: nodejs#9887
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants