Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rename writing_tests.md to writing-tests.md #9867

Closed

Conversation

captainsafia
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The writing_tests.md file did not utilize snake-case as the other files
in the directory did.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 1, 2016
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor

doc: standardize casing in doc/guides

There were no changes to case in this PR, commit message should be

doc: rename writing_tests.md to writing-tests.md

@Trott
Copy link
Member

Trott commented Dec 1, 2016

There were no changes to case in this PR, commit

Change was from snake_case to kebab-case. But yeah, "casing" ambiguous and your more explicit suggestion is better.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 2, 2016

Probably not a big deal, but this will break links to the doc from at least a couple other GitHub issues.

The writing_tests.md file did not utilize snake-case as the other files
in the directory did.
@captainsafia
Copy link
Contributor Author

Change was from snake_case to kebab-case. But yeah, "casing" ambiguous and your more explicit suggestion is better.

Fixed!

Probably not a big deal, but this will break links to the doc from at least a couple other GitHub issues.

True. Although only 3 instances from what I could find so not too bad...

@captainsafia captainsafia changed the title doc: standardize casing in doc/guides doc: rename writing_tests.md to writing-tests.md Dec 2, 2016
@targos
Copy link
Member

targos commented Dec 3, 2016

Landed in 947baaf

@targos targos closed this Dec 3, 2016
targos pushed a commit that referenced this pull request Dec 3, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@captainsafia captainsafia deleted the fix-writing-tests-casing branch December 3, 2016 18:41
addaleax pushed a commit that referenced this pull request Dec 5, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: nodejs#9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
The writing_tests.md file did not utilize kebab-case as the other files
in the directory did.

PR-URL: #9867
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants