Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:refactor test-tls-hello-parser-failure #9715

Closed
wants to merge 2 commits into from
Closed

test:refactor test-tls-hello-parser-failure #9715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e13e4
test:refactor test-tls-hello-parser-failure
Trott Nov 21, 2016
98abcf3
squash: add another common.mustCall()
Trott Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 22 additions & 25 deletions test/parallel/test-tls-hello-parser-failure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,43 @@
'use strict';
var common = require('../common');
var assert = require('assert');

const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');

var net = require('net');
var fs = require('fs');
const assert = require('assert');
const tls = require('tls');

const net = require('net');
const fs = require('fs');

var options = {
const options = {
key: fs.readFileSync(common.fixturesDir + '/test_key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem')
};

var bonkers = Buffer.alloc(1024 * 1024, 42);
const bonkers = Buffer.alloc(1024 * 1024, 42);

var server = tls.createServer(options, function(c) {
const server = tls.createServer(options, function(c) {

}).listen(0, function() {
var client = net.connect(this.address().port, function() {
}).listen(0, common.mustCall(function() {
const client = net.connect(this.address().port, common.mustCall(function() {
client.write(bonkers);
});
}));

var once = false;

var writeAgain = setTimeout(function() {
const writeAgain = setImmediate(function() {
client.write(bonkers);
});

client.on('error', function(err) {
if (!once) {
clearTimeout(writeAgain);
once = true;
client.destroy();
server.close();
}
});
client.once('error', common.mustCall(function(err) {
clearImmediate(writeAgain);
client.destroy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap the listener with common.mustCall()?

server.close();
}));

client.on('close', function(hadError) {
client.on('close', common.mustCall(function(hadError) {
assert.strictEqual(hadError, true, 'Client never errored');
});
});
}));
}));