Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: cctest TAP output changes #9682

Closed
wants to merge 6 commits into from
Closed

backport: cctest TAP output changes #9682

wants to merge 6 commits into from

Commits on Nov 18, 2016

  1. deps: make gtest output tap 

    Teach gtest to produce TAP so we can integrate it better with our CI
tooling.

TAP is printed to stdout but it can also be written to file by passing
the `--gtest_output=tap:filename.tap` switch to cctest.

PR-URL: nodejs#8034
Reviewed-By: James M Snell <[email protected]>
    @bnoordhuis @mscdex
    bnoordhuis authored and mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    f72f02f View commit details
    Browse the repository at this point in the history

  2. build: run cctests as part of test-ci target 

    Enable the cctests on the CI now that they know how to write TAP output.

PR-URL: nodejs#8034
Reviewed-By: James M Snell <[email protected]>
    @bnoordhuis @mscdex
    bnoordhuis authored and mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    938e67a View commit details
    Browse the repository at this point in the history

  3. deps: revert default gtest reporter change 

    PR-URL: nodejs#8948
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @mscdex
    mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    7f81919 View commit details
    Browse the repository at this point in the history

  4. test: output tap13 instead of almost-tap 

    Produce a tap13-compatible output which makes it
simpler to parse. Output is still readable by
the jenkins tap plugin.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
    @jbergstroem @mscdex
    jbergstroem authored and mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    d2693b1 View commit details
    Browse the repository at this point in the history

  5. gtest: output tap comments as yamlish 

    This makes yaml-ish parsers happy.
Note: gtest still seems to output the expected/result slightly
different making the full traceback less informational.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
    @jbergstroem @mscdex
    jbergstroem authored and mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    a7d90df View commit details
    Browse the repository at this point in the history

  6. gitignore: ignore all tap files 

    We now have multiple tap producers; just ignore all
files with the `.tap` extension.

PR-URL: nodejs#9262
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
    @jbergstroem @mscdex
    jbergstroem authored and mscdex committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    0b8be2a View commit details
    Browse the repository at this point in the history