(WIP) lib: fix beforeExit not working with -e #9680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
added
lib / src
nodejs-github-bot
added
c++
Commit 93a44d5 ("src: fix deferred events not working with -e") defers evaluation of the script to the next tick. A side effect of that change is that 'beforeExit' listeners run before the actual script. 'beforeExit' is emitted when the event loop is empty but process.nextTick() does not ref the event loop. Fix that by using setImmediate(). Because it is implemented in terms of a uv_check_t handle, it interacts with the event loop properly. Ref: nodejs#9680 Fixes: nodejs#8534 PR-URL: nodejs#8821 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
force-pushed
the
backport-8821-fix-before-exit
branch
from
135218e
to
25c3207
Compare
MylesBorins
force-pushed
the
v4.x-staging
branch
from
d860f6e
to
c77ba8c
Compare
MylesBorins
force-pushed
the
v4.x-staging
branch
from
f5c57c7
to
735119c
Compare
MylesBorins
force-pushed
the
v4.x-staging
branch
from
bba3dcf
to
6fa3c73
Compare
|
ping @MylesBorins ... is this still in consideration for v4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, lib
Description of change
This is an attempted backport of c5b07d4 to v4.x
It involved manually recreating the entire commit, as
bootstrap_node.jsdoes not exist in v4.x and the stack traces for the tests are quite different.Unfortunately when running the tests we are seeing a failure in
test/parallel/test-debug-brk.js. The node process for that test is not exiting and it is leaving phantom processes running 👻Please do not run this in CI until we have figured out what is going on with the phantom processes.
@bnoordhuis do you have any idea why this is happening?
/cc @nodejs/lts