Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use ABORT() macro instead of abort() #9613

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

evanlucas
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 15, 2016
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: nodejs#9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas
Copy link
Contributor Author

Landed in 21826ef. Thanks!

@evanlucas evanlucas merged commit 21826ef into nodejs:master Nov 17, 2016
Fishrock123 pushed a commit that referenced this pull request Nov 22, 2016
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

@evanlucas this will need to be manually backported

@sam-github
Copy link
Contributor

backported in #10969

sam-github pushed a commit to sam-github/node that referenced this pull request Feb 14, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: nodejs#9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants