Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_base: remove static JSMethod declarations #957

Closed
wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Feb 25, 2015

Move JS methods to the stream_base-inl.h and thus define them on each
use of StreamBase::AddMethods. Inline AddMethods itself, so that
there won't be any need in a static declaration in stream_base.cc.

NOTE: This basically allows using this API in user-land, though, some
polishing is required before releasing it.

cc @piscisaureus @iojs/streams @chrisdickinson

Move JS methods to the stream_base-inl.h and thus define them on each
use of `StreamBase::AddMethods`. Inline `AddMethods` itself, so that
there won't be any need in a static declaration in stream_base.cc.

NOTE: This basically allows using this API in user-land, though, some
polishing is required before releasing it.
@chrisdickinson
Copy link
Contributor

LGTM.

indutny added a commit that referenced this pull request Feb 25, 2015
Move JS methods to the stream_base-inl.h and thus define them on each
use of `StreamBase::AddMethods`. Inline `AddMethods` itself, so that
there won't be any need in a static declaration in stream_base.cc.

NOTE: This basically allows using this API in user-land, though, some
polishing is required before releasing it.

PR-URL: #957
Reviewed-By: Chris Dickinson <[email protected]>
@indutny
Copy link
Member Author

indutny commented Feb 25, 2015

Landed in 06dafc9, thank you!

@indutny indutny closed this Feb 25, 2015
@indutny indutny deleted the feature/awesome-stream-base branch February 25, 2015 20:02
indutny added a commit that referenced this pull request Feb 25, 2015
Move JS methods to the stream_base-inl.h and thus define them on each
use of `StreamBase::AddMethods`. Inline `AddMethods` itself, so that
there won't be any need in a static declaration in stream_base.cc.

NOTE: This basically allows using this API in user-land, though, some
polishing is required before releasing it.

PR-URL: #957
Reviewed-By: Chris Dickinson <[email protected]>
@rvagg
Copy link
Member

rvagg commented Feb 25, 2015

force pushed master, this is now 89e133a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants