Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix link to cli.md in vm.md #9481

Closed
wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Nov 5, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Looks like the link for cli.md is missing:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code

Added the link which can be verified by using the following commands:

$ make doc
$ open out/doc/api/vm.html

Looks like the link to cli.md is missing in vm.md:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code

Added the link which can be verified by using the following commands:
$ make doc
$ open out/doc/api/vm.html
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Nov 5, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Nov 7, 2016

Would it work to change [command line option][cli.md] to [command line option][] and at the bottom do [command line option]: cli.html?

@danbev
Copy link
Contributor Author

danbev commented Nov 8, 2016

Would it work to change [command line option][cli.md] to [command line option][] and at the bottom do [command line option]: cli.html?

Ah, that works and is more inline with what the other links do. Thanks for that!

danbev added a commit to danbev/node that referenced this pull request Nov 8, 2016
Looks like the link to cli.md is missing in vm.md:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code

Added the link which can be verified by using the following commands:
$ make doc
$ open out/doc/api/vm.html

PR-URL: nodejs#9481
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Nov 8, 2016

Landed in 5734361

@danbev danbev closed this Nov 8, 2016
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
Looks like the link to cli.md is missing in vm.md:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code

Added the link which can be verified by using the following commands:
$ make doc
$ open out/doc/api/vm.html

PR-URL: #9481
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2016
Looks like the link to cli.md is missing in vm.md:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code

Added the link which can be verified by using the following commands:
$ make doc
$ open out/doc/api/vm.html

PR-URL: #9481
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
@danbev danbev deleted the fix-cli-link-in-vm-doc branch January 17, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants