Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix inaccuracy in https.request docs #9453

Closed
wants to merge 1 commit into from
Closed

doc: Fix inaccuracy in https.request docs #9453

wants to merge 1 commit into from

Conversation

papandreou
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc (https)

Description of change

Remove misleading statement about require('https').globalAgent silently ignoring options passed to require('https').request. Refer to discussion in #9324.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem. labels Nov 3, 2016
@papandreou papandreou mentioned this pull request Nov 3, 2016
Closed
@sam-github
Copy link
Contributor

lgtm

mhdawson
mhdawson approved these changes Nov 9, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Nov 9, 2016

CI run here (maybe not absolutely necessary but will make sure any doc checks are completed):https://ci.nodejs.org/job/node-test-pull-request/4814/

@mhdawson mhdawson self-assigned this Nov 10, 2016
@mhdawson
Copy link
Member

CI run looks good will land.

@mhdawson
Copy link
Member

landed as ca57912

@mhdawson mhdawson closed this Nov 10, 2016
mhdawson pushed a commit that referenced this pull request Nov 10, 2016
@papandreou @mhdawson
doc: Fix inaccuracy in https.request docs
ca57912 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@papandreou @addaleax
doc: Fix inaccuracy in https.request docs
c07f648 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@papandreou @MylesBorins
doc: Fix inaccuracy in https.request docs
3f39a39 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@papandreou @MylesBorins
doc: Fix inaccuracy in https.request docs
2d581f1 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@papandreou @MylesBorins
doc: Fix inaccuracy in https.request docs
a39a409 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@papandreou @MylesBorins
doc: Fix inaccuracy in https.request docs
39996f9 
PR-URL: #9453
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

@mhdawson mhdawson

Labels
doc Issues and PRs related to the documentations. https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@papandreou @sam-github @mhdawson @silverwind @jasnell @cjihrig @MylesBorins @nodejs-github-bot