Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update libuv to 1.4.1 #940

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

R=@indutny, /cc @rvagg

@indutny
Copy link
Member

indutny commented Feb 24, 2015

LGTM if CI is happy.

@rvagg
Copy link
Member

rvagg commented Feb 24, 2015

lgtm

@bnoordhuis
Copy link
Member Author

RE: CI, there are two runs in progress at the moment. I'm waiting for them to complete before I start testing this one.

@rvagg
Copy link
Member

rvagg commented Feb 24, 2015

@bnoordhuis just queue it up even if there are runs in play, many of the targets have multiple slaves to make it workable and they'll queue in any case but you'll still have the number / url

@bnoordhuis
Copy link
Member Author

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/192/ - I've had concurrent runs interact poorly with each other in the past (e.g. hitting the system-wide file descriptor limit) but let's hope for the best.

bnoordhuis added a commit that referenced this pull request Feb 25, 2015
PR-URL: #940
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@rvagg
Copy link
Member

rvagg commented Feb 25, 2015

landed @ 739fda1

@rvagg rvagg closed this Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants