Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up program/isolate/env init logic #9224

Merged
merged 2 commits into from
Oct 24, 2016
Merged

src: clean up program/isolate/env init logic #9224

merged 2 commits into from
Oct 24, 2016

Commits on Oct 24, 2016

  1. src: simplify code, remove NodeInstanceData 

    NodeInstanceData is not used meaningfully and makes the initialization
logic harder to follow.  Let's remove it and delete 100 lines of code
in one fell swoop.

PR-URL: nodejs#9224
Reviewed-By: James M Snell <[email protected]>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    d77e818 View commit details
    Browse the repository at this point in the history

  2. src: clean up program/isolate/env init logic 

    Reorder the initialization logic so that program-wide, per-isolate and
per-environment initialization is more cleanly separated.

PR-URL: nodejs#9224
Reviewed-By: James M Snell <[email protected]>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    ceb6023 View commit details
    Browse the repository at this point in the history