Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix header level for crypto.constants #9187

Closed
wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The header level for crypto.constants was off by one.

The header level for crypto.constants was off by one.
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 19, 2016
@jasnell
Copy link
Member

jasnell commented Oct 19, 2016

LGTM. trivial enough to not wait the full 48 hours.

@jasnell jasnell self-assigned this Oct 19, 2016
jasnell pushed a commit that referenced this pull request Oct 19, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 19, 2016

Landed in ca3c8a9.

@jasnell jasnell closed this Oct 19, 2016
@evanlucas evanlucas deleted the cryptodocheader branch October 19, 2016 17:24
jasnell pushed a commit that referenced this pull request Oct 20, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
The header level for crypto.constants was off by one.

PR-URL: #9187
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants