Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark fixes #9064

Closed
wants to merge 3 commits into from
Closed

Benchmark fixes #9064

wants to merge 3 commits into from

Commits on Oct 12, 2016

  1. benchmark: fixes csv parsing given no parameters 

    When a benchmark did not contain any parameters the csv configuration
filed would be "". In R this is by default parsed as NA, causing NA in
the printout too.

Fixes: #9061
    @AndreasMadsen
    AndreasMadsen committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    6ae4021 View commit details
    Browse the repository at this point in the history

  2. benchmark: change the execution order 

    This changes the execution order from "iter, file, binary" to "file,
iter, binary". This means the csv no longer has to buffered completely.

This also has the added effect that stopping compare.js early or
interfering with performance only affects a single benchmark, instead of
all of them.

Refs: #8659
    @AndreasMadsen
    AndreasMadsen committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    d3870a5 View commit details
    Browse the repository at this point in the history

  3. benchmark: use node v4 syntax in common.js 

    Using new syntax such as `...args` means that the benchmark suite can't
be used with older node versions. This changes the `...args` syntax to a
good old `Array.prototype.slice`.

Refs: #8932 (comment)
    @AndreasMadsen
    AndreasMadsen committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    09d6531 View commit details
    Browse the repository at this point in the history