Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup/update test-dgram-error-message-address.js #8938

Closed
wants to merge 1 commit into from
Closed

test: cleanup/update test-dgram-error-message-address.js #8938

wants to merge 1 commit into from

Conversation

Goyapa
Copy link
Contributor

@Goyapa Goyapa commented Oct 5, 2016 •
edited by imyller
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test
dgram

Description of change

test: cleanup/update test-dgram-error-message-address.js

* Changed some var to const
* This commit resolves #8925

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 5, 2016
@Goyapa Goyapa changed the title Test dgram error message test: cleanup/update test-dgram-error-message-address.js Oct 5, 2016
cjihrig
cjihrig approved these changes Oct 5, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is some other cleanup that you could do while you're here. Like getting rid of assert.equal() and assert.notEqual().

@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 5, 2016
@Trott
Copy link
Member

Trott commented Oct 5, 2016 •
edited
Loading

  • Can you rebase/squash so that there aren't unrelated commits in the PR?

These changes would make this change more compelling:

  • assert.equal() -> assert.strictEqual()
  • assert.notEqual() -> assert.notStrictEqual()
  • The use of common.fail can be improved. Perhaps create a function that wraps it so that it prints a sensible message.

@imyller imyller mentioned this pull request Oct 7, 2016
Closed
@imyller
Copy link
Member

imyller commented Oct 7, 2016

Fixes: #8925

@lpinca
Copy link
Member

lpinca commented Oct 12, 2016 •
edited
Loading

@Goyapa while you are at it can you please replace assert.equal() with assert.strictEqual() and assert.notEqual() with assert.notStrictEqual().

Also you can use the Fixes: metadata instead of This commit resolves #8925 as defined in CONTRIBUTING.md.

@Goyapa
Copy link
Contributor Author

Goyapa commented Oct 13, 2016

@ipinca
My Laptop died, an i do not know when i am able to continue.
Sorry, how to process now?

@lpinca
Copy link
Member

lpinca commented Oct 13, 2016

@Goyapa we can use https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ if it is not a problem for you.

@addaleax
Copy link
Member

You can also try to edit files on your branch using Github’s web interface, it’s a bit tricky but it’s nice when you don’t want to or can’t use a local git client.

@Goyapa
Copy link
Contributor Author

Goyapa commented Oct 13, 2016

@lpinca
Allow edits from maintainers is checked v.

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@Goyapa
Copy link
Contributor Author

Goyapa commented Nov 5, 2016

@lpinca
See that nothing has changed at this file on master.
I`m on it again!

@Goyapa
test: cleanup/update test-dgram-error-message-address.js
9c8fb2f 
* Changes:

* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

* Fixes: #8925
@targos
Copy link
Member

targos commented Nov 27, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5006/

@targos
Copy link
Member

targos commented Nov 28, 2016

Landed in 6a73d61

@targos targos closed this Nov 28, 2016
targos pushed a commit that referenced this pull request Nov 28, 2016
@Goyapa @targos
test: cleanup test-dgram-error-message-address
6a73d61 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 30, 2016
@Goyapa @MylesBorins
test: cleanup test-dgram-error-message-address
24fc1e2 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 30, 2016
@Goyapa @MylesBorins
test: cleanup test-dgram-error-message-address
9144d37 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 1, 2016
Merged
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@Goyapa @addaleax
test: cleanup test-dgram-error-message-address
d06f010 
* var -> const
* assert.equal() -> assert.strictEqual()
* assert.notEqual() -> assert.notStrictEqual()

Fixes: #8925
PR-URL: #8938
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
@MylesBorins MylesBorins mentioned this pull request Dec 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.