Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding test for _stream_writable.js needDrain state #8799

Closed
wants to merge 1 commit into from
Closed

adding test for _stream_writable.js needDrain state #8799

wants to merge 1 commit into from

Conversation

italoacasas
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test
Description of change
  • Adding tests for stream._writableState.needDrain

Issue related: #8686

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 27, 2016
@lpinca lpinca added the stream Issues and PRs related to the stream subsystem. label Sep 27, 2016
jasnell
jasnell reviewed Sep 27, 2016
View reviewed changes
test/parallel/test-stream-writable-needdrain-state.js

assert.strictEqual(transform._writableState.needDrain, false);

transform.write('asdasd', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this callback should be wrapped in a common.mustCall() to ensure that it's actually called.

addaleax
addaleax approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Sep 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4334/

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@italoacasas
Copy link
Contributor Author

@mcollina ping

mcollina
mcollina approved these changes Oct 26, 2016
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

Ci: https://ci.nodejs.org/job/node-test-pull-request/4681/

@mcollina
Copy link
Member

Failures unrelated. This is good to go, I'm planning on merging tomorrow or Friday, if no one else has objections.

@mcollina
Copy link
Member

mcollina commented Oct 28, 2016 •
edited
Loading

Merged in 9ed7261

@mcollina mcollina closed this Oct 28, 2016
mcollina pushed a commit that referenced this pull request Oct 28, 2016
@italoacasas @mcollina
test: writable stream needDrain state
9ed7261 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Related: #8686
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@italoacasas @evanlucas
test: writable stream needDrain state
c9b67c6 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Related: #8686
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@italoacasas
test: writable stream needDrain state
4b50419 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@italoacasas
test: writable stream needDrain state
40ef239 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@italoacasas @MylesBorins
test: writable stream needDrain state
1fee6c1 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Related: #8686
This was referenced Nov 22, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@italoacasas @jasnell @mcollina @addaleax @cjihrig @MylesBorins @lpinca @nodejs-github-bot