Update ESLint, replace custom rule with built-in

.eslintrc

@@ -54,6 +54,11 @@ rules:
   no-new-require: 2
   no-path-concat: 2
   no-restricted-modules: [2, sys, _linklist]
+  no-restricted-properties: [2, {
+    object: assert,
+    property: deepEqual,
+    message: Please use assert.deepStrictEqual().
+  }]
 
   # Stylistic Issues
   # http://eslint.org/docs/rules/#stylistic-issues
@@ -98,7 +103,6 @@ rules:
   align-multiline-assignment: 2
   assert-fail-single-argument: 2
   new-with-error: [2, Error, RangeError, TypeError, SyntaxError, ReferenceError]
-  no-deepEqual: 2
   no-definegetter-definesetter: 2
 
 # Global scoped method and vars

benchmark/assert/deepequal-prims-and-objs-big-array.js

@@ -1,4 +1,3 @@
-/* eslint no-deepEqual: 0 */
 'use strict';
 var common = require('../common.js');
 var assert = require('assert');
@@ -35,6 +34,7 @@ function main(conf) {
 
   bench.start();
   for (x = 0; x < n; x++) {
+    // eslint-disable-next-line no-restricted-properties
     assert.deepEqual(primArray, primArrayCompare);
   }
   bench.end(n);

benchmark/assert/deepequal-prims-and-objs-big-loop.js

@@ -1,4 +1,3 @@
-/* eslint no-deepEqual: 0 */
 'use strict';
 var common = require('../common.js');
 var assert = require('assert');
@@ -27,6 +26,7 @@ function main(conf) {
   bench.start();
 
   for (x = 0; x < n; x++) {
+    // eslint-disable-next-line no-restricted-properties
     assert.deepEqual(new Array([prim]), new Array([prim]));
   }
 

benchmark/assert/deepequal-typedarrays.js

@@ -1,4 +1,3 @@
-/* eslint no-deepEqual: 0 */
 'use strict';
 var common = require('../common.js');
 var assert = require('assert');
@@ -17,6 +16,7 @@ function main(conf) {
   var actual = new clazz(n * 1e6);
   var expected = new clazz(n * 1e6);
 
+  // eslint-disable-next-line no-restricted-properties
   assert.deepEqual(actual, expected);
 
   bench.end(n);

lib/assert.js

@@ -126,11 +126,13 @@ assert.notEqual = function notEqual(actual, expected, message) {
 // 7. The equivalence assertion tests a deep equality relation.
 // assert.deepEqual(actual, expected, message_opt);
 
+/* eslint-disable no-restricted-properties */
 assert.deepEqual = function deepEqual(actual, expected, message) {
   if (!_deepEqual(actual, expected, false)) {
     fail(actual, expected, message, 'deepEqual', assert.deepEqual);
   }
 };
+/* eslint-enable */
 
 assert.deepStrictEqual = function deepStrictEqual(actual, expected, message) {
   if (!_deepEqual(actual, expected, true)) {

lib/internal/child_process.js

@@ -430,7 +430,7 @@ function setupChannel(target, channel) {
         this.emit('unref');
       }
     }
-  };
+  }();
 
   var decoder = new StringDecoder('utf8');
   var jsonBuffer = '';

test/parallel/test-assert-typedarray-deepequal.js

@@ -1,4 +1,3 @@
-/* eslint no-deepEqual: 0 */
 'use strict';
 
 require('../common');
@@ -46,6 +45,7 @@ const notEqualArrayPairs = [
 ];
 
 equalArrayPairs.forEach((arrayPair) => {
+  // eslint-disable-next-line no-restricted-properties
   assert.deepEqual(arrayPair[0], arrayPair[1]);
 });
 

test/parallel/test-assert.js

@@ -1,4 +1,3 @@
-/* eslint no-deepEqual: 0 */
 'use strict';
 require('../common');
 var assert = require('assert');

test/parallel/test-stream2-readable-from-list.js

@@ -23,7 +23,7 @@ function run() {
   var fn = next[1];
   console.log('# %s', name);
   fn({
-    same: assert.deepEqual,
+    same: assert.deepStrictEqual,
     equal: assert.equal,
     end: function() {
       count--;

test/parallel/test-stream2-set-encoding.js

@@ -22,7 +22,7 @@ function run() {
   var fn = next[1];
   console.log('# %s', name);
   fn({
-    same: assert.deepEqual,
+    same: assert.deepStrictEqual,
     equal: assert.equal,
     end: function() {
       count--;

test/parallel/test-stream2-transform.js

@@ -22,7 +22,7 @@ function run() {
   var fn = next[1];
   console.log('# %s', name);
   fn({
-    same: assert.deepEqual,
+    same: assert.deepStrictEqual,
     equal: assert.equal,
     ok: assert,
     end: function() {

test/parallel/test-stream2-writable.js

@@ -45,7 +45,7 @@ function run() {
   var fn = next[1];
   console.log('# %s', name);
   fn({
-    same: assert.deepEqual,
+    same: assert.deepStrictEqual,
     equal: assert.equal,
     end: function() {
       count--;

test/parallel/test-timer-close.js

@@ -2,7 +2,7 @@
 require('../common');
 var assert = require('assert');
 
-var t = new (process.binding('timer_wrap').Timer);
+var t = new (process.binding('timer_wrap').Timer)();
 var called = 0;
 function onclose() {
   called++;

test/parallel/test-util-inspect.js

@@ -792,7 +792,7 @@ checkAlignment(new Map(big_array.map(function(y) { return [y, null]; })));
 }
 
 {
-  const x = new function() {};
+  const x = new function() {}; // eslint-disable-line new-parens
   assert.strictEqual(util.inspect(x), '{}');
 }
 

test/parallel/test-util.js

@@ -30,6 +30,7 @@ assert.equal(false, util.isRegExp(Object.create(RegExp.prototype)));
 // isDate
 assert.equal(true, util.isDate(new Date()));
 assert.equal(true, util.isDate(new Date(0)));
+// eslint-disable-next-line new-parens
 assert.equal(true, util.isDate(new (context('Date'))));
 assert.equal(false, util.isDate(Date()));
 assert.equal(false, util.isDate({}));
@@ -41,9 +42,11 @@ assert.equal(false, util.isDate(Object.create(Date.prototype)));
 assert.equal(true, util.isError(new Error()));
 assert.equal(true, util.isError(new TypeError()));
 assert.equal(true, util.isError(new SyntaxError()));
+/* eslint-disable new-parens */
 assert.equal(true, util.isError(new (context('Error'))));
 assert.equal(true, util.isError(new (context('TypeError'))));
 assert.equal(true, util.isError(new (context('SyntaxError'))));
+/* eslint-enable */
 assert.equal(false, util.isError({}));
 assert.equal(false, util.isError({ name: 'Error', message: '' }));
 assert.equal(false, util.isError([]));

test/pummel/test-stream2-basic.js

@@ -85,7 +85,7 @@ function run() {
   var fn = next[1];
   console.log('# %s', name);
   fn({
-    same: assert.deepEqual,
+    same: assert.deepStrictEqual,
     ok: assert,
     equal: assert.equal,
     end: function() {