Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.6.0 proposal #8466

Merged
merged 113 commits into from
Sep 15, 2016
Merged
Changes from 1 commit
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
f829660
deps: cherry-pick 8ed65b97 from V8's upstream
addaleax Sep 5, 2016
6f269be
test: refactor test-util-inspect
Trott Aug 19, 2016
4cb55ff
util: allow symbol-based custom inspection methods
addaleax Aug 18, 2016
e9c4805
util: allow returning `this` from custom inspect
addaleax Aug 18, 2016
eec5d02
url: `url.format()` encodes all `#` in `search`
imyller Aug 11, 2016
6ae7af0
url: keep auth in `url.resolve()` if host matches
imyller Aug 19, 2016
03f5297
doc: include the optional options parameter
thefourtheye Jul 22, 2016
e4fcf55
doc: fix "timout" typo in timeout
hefangshi Aug 23, 2016
a7c2175
doc: fix buf.readUIntBE, buf.readUIntLE examples
mozkeeler Aug 23, 2016
260663f
doc: add Myles Borins to the CTC
rvagg Aug 24, 2016
93ac875
doc: add `added:` information for dgram
lpinca Aug 20, 2016
2ecc8c4
async_wrap: add a missing case to test-async-wrap-throw-no-init
yorkie Aug 20, 2016
206b105
build: add missing files to zip and 7z packages
richardlau Aug 11, 2016
bc9d2fb
build: fix dependencies on AIX
mhdawson Aug 25, 2016
0f977f9
test: mark test-child-process-fork-dgram as flaky
mhdawson Aug 25, 2016
d67ece2
util: improve function signature of util._extend
thefourtheye Aug 20, 2016
0b0a1ce
test: clean up / refactor buffer tests, remove duplication
jasnell Aug 23, 2016
fa4c4d6
http: fix connection upgrade checks
mscdex Aug 23, 2016
5cff625
test: add check in test-signal-handler
Trott Aug 24, 2016
b6f5104
doc: fix onReadable reentry after unshift called
Aug 21, 2016
6f20f47
repl: Auto alignment for .editor mode
princejwesley Aug 23, 2016
3ef8ba8
net: make holding the buffer in memory more robust
addaleax Aug 24, 2016
d565183
doc: add `added:` information for modules
lpinca Aug 24, 2016
d2179bd
test: make sure over truncation of file zero fills
thefourtheye Aug 27, 2016
47ecd21
doc: improve fs.truncate functions' documentation
thefourtheye Aug 27, 2016
836bfc1
build: fix dependencies on AIX
mhdawson Aug 26, 2016
5d43131
test: add known issue test for path parse issue #6229
jasnell Aug 27, 2016
48be8bc
doc: `'ipc'` is required with fork stdio option
jasnell Aug 27, 2016
bc6a7ca
test: additional refactoring/cleanup of buffer tests
jasnell Aug 26, 2016
54d7613
doc: readline write() is processed as input
jasnell Aug 27, 2016
d2b2abe
doc: doc that listen can be called multiple times
jasnell Aug 27, 2016
cde0a1e
test: refactor test-debug-signal-cluster
Trott Aug 26, 2016
feab3d4
doc: add lpinca to collaborators
lpinca Aug 30, 2016
ac3471c
deps: v8_inspector update
Aug 23, 2016
354166c
inspector: use new inspector headers
Aug 15, 2016
605db31
events: make memory leak warning more accessible
addaleax Aug 27, 2016
54f689f
tools: update ESLint to 3.4.0
Trott Aug 27, 2016
773e1c1
tools: enable caching for jslint task
Trott Aug 27, 2016
b553e57
doc: clarify that path on windows accepts / and \
jasnell Aug 27, 2016
cc61d1a
test: cleanup test require symlink
paulgrock Aug 27, 2016
40e8421
test: add test for zlib.create*Raw()
Trott Aug 28, 2016
250a380
inspector: simplify buffer management
Aug 24, 2016
13a522a
inspector: make sure all messages are dispatched
Aug 24, 2016
0f2c619
src: avoid duplicate AtExit functions
ofrobots Aug 25, 2016
59e96bb
doc: adding danbev to collaborators
danbev Aug 30, 2016
39cf7bf
test: refactor parallel/test-process-env.js
Trott Aug 28, 2016
c8bcf1b
deps: workaround clang-3.4 ICE
ofrobots Aug 30, 2016
9f18878
doc: fix typo in stream doc
hubertmine Aug 29, 2016
a830e37
build: don't require processing docs for nightlies
jbergstroem Aug 29, 2016
1aa7168
test: refactor/cleanup a number of cluster tests
jasnell Aug 24, 2016
372e4f3
doc: bad/better examples for fs.access() and fs.exists()
dfabulich Jul 22, 2016
c07e063
test: fix `fs-watch-recursive` flakiness on OS X
santigimeno Jan 11, 2016
76a3050
doc: update landing pr info in onboarding doc
Trott Aug 30, 2016
b8fa7c9
test: fix ::1 error in test-dns-ipv6
gibfahn Aug 26, 2016
fbabd36
doc: update targos email in readme per request
jasnell Sep 2, 2016
6d421a2
doc: fix broken link in dgram doc
mscdex Sep 1, 2016
f0300ed
test: fix test-cluster-dgram-1 flakiness
santigimeno Sep 2, 2016
680a4c8
test: test non-buffer/string with zlib
Trott Aug 31, 2016
b603ac2
inspector: use script name for target title
Jun 10, 2016
65096de
doc: fix typos
MikeRalphson Sep 1, 2016
1695c84
doc: fix a wrong link,add '.md' to the link
Alexis374 Aug 29, 2016
ee83f5d
doc: add return type of clientRequest.setTimeout
MikeRalphson Aug 31, 2016
44983b1
doc: update authors list
jasnell Aug 30, 2016
ca31187
doc: update CI content in onboarding doc
Trott Sep 1, 2016
4e368c5
src: moving f function call comment
danbev Sep 4, 2016
2c2a21a
src: unbreak build when compiling against uclibc
bnoordhuis Aug 28, 2016
6d07e57
test: mark pseudo-tty/no_dropped_stdio as flaky
mhdawson Sep 2, 2016
d0a92be
doc: add 2016-08-10 CTC meeting minutes
joshgav Aug 22, 2016
d1d1433
src: normalize malloc, realloc
mhdawson Sep 1, 2016
49f996f
crypto: make malloc failure check cross-platform
Trott Aug 31, 2016
dd51b1f
buffer,string_decoder: consolidate encoding validation logic
jasnell Jun 7, 2016
9c460d7
deps: add back no-op harmony shipping flags
ofrobots Sep 8, 2016
1640e7a
crypto: fix getDecoder() encoding check
atstoyanov Aug 27, 2016
fdd59cc
doc: update BUILDING.md
Trott Sep 3, 2016
d536d6d
test: increase _debugger coverage
Trott Sep 4, 2016
8cbbb47
src: update f function call comment
danbev Sep 6, 2016
cffe7b7
doc: add 2016-08-17 CTC meeting minutes
joshgav Aug 23, 2016
afb9917
crypto: add crypto.timingSafeEqual()
not-an-aardvark Aug 24, 2016
81d063e
win,build: fail on invalid option in vcbuild
joaocgreis Sep 1, 2016
14d356d
win,build: skip finding VS when not needed
joaocgreis Sep 4, 2016
6bb057e
win,build: exit when addons fail to build
joaocgreis Sep 5, 2016
2c45782
doc: add CI help/support info to onboarding doc
Trott Sep 5, 2016
151d1ea
vm: change ContextifyScript to Script in comment
danbev Sep 6, 2016
408308f
readline: key interval delay for \r & \n
princejwesley Aug 15, 2016
f346dee
win,build: forward release_urlbase to configure
joaocgreis Sep 7, 2016
c7771e6
doc: clarify sentence in event loop doc
lpinca Sep 3, 2016
6c30ddd
test: exercise EE function type checking paths
cjihrig Aug 18, 2016
1620226
src: remove unneeded Environment error methods
bnoordhuis Sep 6, 2016
0d24247
src: pull AfterConnect from pipe_wrap and tcp_wrap
danbev Jul 24, 2016
3ce6eaa
doc: note that listening on SIGSEGV & co is unsafe
addaleax Sep 5, 2016
7cc1391
benchmark: fix off-by-one error in fs benchmarks
addaleax Aug 30, 2016
00f4bc3
benchmark: add benches for fs.stat & fs.statSync
addaleax Aug 30, 2016
19df5ce
doc: fix example in repl documentation
fhinkel Sep 9, 2016
154d689
test: add test-debug-protocol-execute
Trott Sep 8, 2016
d0e61d4
test: make crypto.timingSafeEqual test less flaky
not-an-aardvark Sep 8, 2016
09da575
doc: add `added:` information for crypto
lpinca Aug 26, 2016
6e3db28
buffer: fix ArrayBuffer checks
mscdex Sep 8, 2016
f840bc8
url: fix off-by-one error in loop handling dots
lpinca Sep 6, 2016
5387735
doc: fix link on timers.md
yorkie Sep 11, 2016
5baa4e0
test: clean up net server try ports test
tlhunter Sep 9, 2016
3294c2c
test: skip pseudo-tty/no_dropped_stdio test
mhdawson Sep 9, 2016
92acff8
doc: add CTC meeting minutes 2016-08-31
joshgav Sep 6, 2016
d2b6b66
test: refactor test-net-pipe-connect-errors
Trott Sep 9, 2016
1a30fe5
test: swapped == and equal to === and strictEqual
HyperSprite Sep 9, 2016
2ce364a
test: modernize JS and tighten equality checking
pogilvie Sep 10, 2016
ef5cb12
tools: fix new-parens violations
Trott Sep 10, 2016
36235ac
tools: update ESLint to 3.5.0
Trott Sep 10, 2016
f47ce9d
tools: replace custom ESLint rule with built-in
Trott Sep 10, 2016
ce1a46c
doc: update onboarding PR landing info
Trott Sep 10, 2016
3358861
test: refector parallel/test-http.js
jun-oka Sep 9, 2016
eff771f
tickprocessor: apply c++filt manually on mac
indutny Sep 10, 2016
c48cb2d
doc: link SIGTSTP / SIGCONT events in readline doc
italoacasas Sep 10, 2016
0a3ad92
2016-09-14, Version 6.6.0 (Current)
Fishrock123 Sep 14, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: cherry-pick 8ed65b97 from V8's upstream
Original commit message:

    Make FieldType::None() non-nullptr value to avoid undefined behaviour

    When FieldType::None() returns a cast Smi::FromInt(0), which translates
    as nullptr, the FieldType::IsNone() check becomes equivalent to
    `this == nullptr` which is not allowed by the standard and
    therefore optimized away as a false constant by GCC 6.

    This has lead to crashes when invoking methods on FieldType::None().

    Using a different Smi constant for FieldType::None() makes the compiler
    always include a comparison against that value. The choice of these
    constants has no effect as they are effectively arbitrary.

    BUG=#8310

    Review-Url: https://codereview.chromium.org/2292953002
    Cr-Commit-Position: refs/heads/master@{#39023}

Fixes: #8310
PR-URL: #8411
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information
addaleax committed Sep 8, 2016
commit f829660c71a1925fbd502f91a4e041683ab28466
4 changes: 3 additions & 1 deletion deps/v8/src/field-type.cc
Original file line number Diff line number Diff line change
@@ -13,7 +13,9 @@ namespace internal {

// static
FieldType* FieldType::None() {
return reinterpret_cast<FieldType*>(Smi::FromInt(0));
// Do not Smi::FromInt(0) here or for Any(), as that may translate
// as `nullptr` which is not a valid value for `this`.
return reinterpret_cast<FieldType*>(Smi::FromInt(2));
}

// static
11 changes: 11 additions & 0 deletions deps/v8/test/cctest/test-field-type-tracking.cc
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@
#include "src/global-handles.h"
#include "src/ic/stub-cache.h"
#include "src/macro-assembler.h"
#include "src/types.h"

using namespace v8::internal;

@@ -2473,6 +2474,16 @@ TEST(TransitionAccessorConstantToSameAccessorConstant) {
TestTransitionTo(transition_op, transition_op, checker);
}

TEST(FieldTypeConvertSimple) {
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());
Isolate* isolate = CcTest::i_isolate();

Zone zone(isolate->allocator());

CHECK_EQ(FieldType::Any()->Convert(&zone), Type::Any());
CHECK_EQ(FieldType::None()->Convert(&zone), Type::None());
}

// TODO(ishell): add this test once IS_ACCESSOR_FIELD_SUPPORTED is supported.
// TEST(TransitionAccessorConstantToAnotherAccessorConstant)