-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add CTC meeting minutes 2016-08-31 #8424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
|
||
@trott: In the issue I see only supportive voices. Any questions or concerns? | ||
|
||
@Fishrock123: Chris (Dickinson?) did some work on making an indexer that could track code paths (?). Just an aside, it’d be nice to get his opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Dickinson.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. LGTY?
joshgav
force-pushed
the
ctc-2016-08-31
branch
from
September 7, 2016 15:56
81ecb1b
to
e352f4c
Compare
LGTM |
joshgav
force-pushed
the
ctc-2016-08-31
branch
from
September 12, 2016 14:53
e352f4c
to
b29cc46
Compare
joshgav
force-pushed
the
ctc-2016-08-31
branch
from
September 12, 2016 14:57
b29cc46
to
b9f7b1f
Compare
PR-URL: nodejs#8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
joshgav
force-pushed
the
ctc-2016-08-31
branch
from
September 12, 2016 15:02
b9f7b1f
to
f1629e7
Compare
landed in f1629e7 |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
PR-URL: #8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8424 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
/cc @nodejs/ctc