Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,build: improvements to vcbuild.bat #8412

Closed
wants to merge 3 commits into from

Conversation

joaocgreis
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, Build.

Description of change

This PR includes 3 changes to vcbuild.bat:

  • 7642724 : Fail and exit immediately when an invalid option is passed to vcbuild.bat. Before there was only a warning, and since the output is quite verbose it was very easy to miss it and vcbuild would run without the options that the user probably wanted.
  • f26497c : When msbuild and other Visual Studio tools are not needed, do not search for Visual Studio. This allows for running the tests in a machine with an unsupported version of VS, or no VS at all. This unblocks src: remove VS 2013 compatibility hacks #8067 , since for v6 onwards we want to build node only with VS2015 but still want to run the tests in machines with VS2013 (node-gyp will detect it independently).
  • f2f2aa4 : When addons fail to build with node-gyp, fail immediately. Before, the build would only fail because the tests would fail later. This makes the output easier to read, since the run ends immediately after the failed node-gyp invocation.

I think the commits should not be squashed because they address different concerns, but I can squash if this is not consensual.

cc @nodejs/platform-windows

@joaocgreis joaocgreis added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Sep 5, 2016
@bnoordhuis
Copy link
Member

LGTM

joaocgreis added a commit that referenced this pull request Sep 8, 2016
joaocgreis added a commit that referenced this pull request Sep 8, 2016
joaocgreis added a commit that referenced this pull request Sep 8, 2016
@joaocgreis
Copy link
Member Author

@joaocgreis joaocgreis closed this Sep 8, 2016
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
@MylesBorins
Copy link
Contributor

@joaocgreis should this be backported?

@joaocgreis
Copy link
Member Author

@thealphanerd yes, I think all of this would also be helpful in v4. Thanks!

MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants