inspector: listen on process.debugPort #8386
Conversation
cjihrig
added
the
semver-major
nodejs-github-bot
added
the
c++
cjihrig
added
debugger
inspector
|
LGTM if CI is green. |
|
@cjihrig this needs a rebase :) |
|
@addaleax rebased. Sorry for the delay. PTAL |
|
CI failures look unrelated. Since this is semver major, can another CTC member take a look? Perhaps @ofrobots? |
|
ping @nodejs/ctc, please. |
|
LGTM |
1 similar comment
|
LGTM |
This commit consolidates the debugging port used by the inspector and Node's legacy debugger. Fixes: nodejs#8201 PR-URL: nodejs#8386 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
Final CI came back OK: https://ci.nodejs.org/job/node-test-pull-request/4040/ |
|
Sorry that I missed the ping on this. The use of different ports between inspector and the old debug protocol was quite intentional due to (very valid) concerns raised by the Debugger implementers: See original PR: #7212. |
|
Was this it?
Given that you can set the port manually, wouldn't debuggers have to be able to determine which protocol was being used with 100% certainty? |
|
The issue is that some debuggers support both the old protocol and new, and when a user requests that the debugger attach to a running process at port 5858, the debugger has no way of knowing with protocol to use. I think this was originally requested by the VSCode folks, but I can't seem to find the discussion (/cc @joshgav, @nojvek). |
|
Discussion on side-by-side ongoing at #8464, would appreciate input from you all there. |
|
/cc @nodejs/diagnostics |
This commit adds a test for the debug port value in cluster workers using the inspector debugger. Refs: nodejs#8201 Refs: nodejs#8386 Refs: nodejs#8550 PR-URL: nodejs#8958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
This commit adds a test for the debug port value in cluster workers using the inspector debugger. Refs: #8201 Refs: #8386 Refs: #8550 PR-URL: #8958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
This commit consolidates the debugging port used by the inspector and Node's legacy debugger. This eliminates any chance of the two debuggers working side by side, but the inspector is currently an unofficial feature, and the legacy debugger should eventually be removed in favor of it.
Fixes: #8201