Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify fields in spawn{Sync} errors #838

Closed
wants to merge 1 commit into from
Closed

test: verify fields in spawn{Sync} errors #838

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 13, 2015

This commit validates the properties of ENOENT error objects returned by spawn() and spawnSync(). This represents the tests requested in #721.

R=@rvagg

This commit validates the properties of ENOENT error objects
returned by spawn() and spawnSync().
@bnoordhuis
Copy link
Member

LGTM

@rvagg
Copy link
Member

rvagg commented Feb 13, 2015

lgtm

/cc @trevnorris @remixz

thanks Colin!

@remixz
Copy link
Contributor

remixz commented Feb 13, 2015

👍 Thanks!

cjihrig added a commit that referenced this pull request Feb 14, 2015
This commit validates the properties of ENOENT error objects
returned by spawn() and spawnSync().

PR-URL: #838
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 14, 2015

Landed in d53b636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants