Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link in dgram doc #8365

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Sep 1, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Fixes a broken link in dgram doc

cluster is referenced in dgram.bind() but is missing in the list of references at the bottom of the doc markdown.

@mscdex mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Sep 1, 2016
@lpinca
Copy link
Member

lpinca commented Sep 1, 2016

How about also adding [] to the markdown link on line 182? This will make it consistent with the others.

@mscdex
Copy link
Contributor Author

mscdex commented Sep 1, 2016

@lpinca I actually prefer leaving off extra trailing [] for links like that. At some point when I get a chance to resume my doc improvement PRs, I will eventually get to dgram.md at which point I will propose dropping the [] everywhere. With that in mind, I don't see a point in making the change now.

@lpinca
Copy link
Member

lpinca commented Sep 1, 2016

Ok. LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Sep 1, 2016

LGTM

@evanlucas
Copy link
Contributor

lgtm

@thefourtheye
Copy link
Contributor

LGTM

PR-URL: nodejs#8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@mscdex mscdex merged commit 8361c26 into nodejs:master Sep 2, 2016
@mscdex mscdex deleted the doc-dgram-fix-typo branch September 2, 2016 18:32
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8365
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants