Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: removed number of jobs from -j option when running make #8287

Conversation

thecoolestguy
Copy link
Contributor

Checklist
  • make -j test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Removing specified number of jobs from -j option in the documentation
steps for running the make command. A '-j' without a number specified
will use the maximum number allowed for any given machine.
Fixes: #8286

Removing specified number of jobs from -j option in the documentation
steps for running the make command. A '-j' without a number specified
will use the maximum number allowed for any given machine.
Fixes: nodejs#8286
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Aug 26, 2016
@bnoordhuis
Copy link
Member

Assuming you're not a troll trying to work a fork bomb into the documentation: make -j without a number puts no upper limit on the level of concurrency, it starts all tasks in parallel.

@Trott
Copy link
Member

Trott commented Aug 26, 2016

Running make clean && make distclean && ./configure && make -j puts the load on my machine way up...it peaked in the high 200s, and then build failed with:

make[1]: *** wait: No child processes.  Stop.

Probably best bet is to just standardize everything on make -j8. Smallest changeset too. Just one file.

@imyller
Copy link
Member

imyller commented Sep 21, 2016

No objections to closing this PR?

Thank you for your effort and contribution though, @thecoolestguy

@imyller imyller self-assigned this Sep 21, 2016
@jbergstroem
Copy link
Member

Agree on close. make -j is essentially forkbombing. 4 cores on a semi-recent laptop is safe for copy paste scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of processes used by 'make' should not be specified in documentation
6 participants