doc: add 2016-08-10 CTC meeting minutes #8229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
|
||
| Enabling inheritance forces the use of `new`. Thus it will break anyone who uses `Buffer` without the `new` keyword. | ||
|
|
||
| @evan: Wasn’t there a way around that? |
There was a problem hiding this comment.
if we are going by username, this should be @evanlucas here and on line 147
|
lgtm with a question |
joshgav
force-pushed
the
ctc-2016-08-10
branch
from
db325aa
to
68753ca
Compare
|
Sorry @evanlucas! Fixed. Would love suggestions on ideal formatting, such as using identifiers other than GH aliases. |
|
|
||
| **Next steps**: | ||
|
|
||
| * Remove global than land EP. |
joshgav
force-pushed
the
ctc-2016-08-10
branch
from
68753ca
to
16c8ead
Compare
|
LGTM |
joshgav
force-pushed
the
ctc-2016-08-10
branch
from
16c8ead
to
12a7afc
Compare
PR-URL: nodejs#8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
joshgav
force-pushed
the
ctc-2016-08-10
branch
from
12a7afc
to
a945244
Compare
|
landed in a945244 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
PR-URL: nodejs#8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
PR-URL: #8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
PR-URL: #8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8229 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
CTC meeting minutes.
/cc @nodejs/ctc