Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add assert.notDeepEqual() tests #8156

Closed
wants to merge 0 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 18, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test assert

Description of change

There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

@Trott Trott added assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests. labels Aug 18, 2016
@Trott
Copy link
Member Author

Trott commented Aug 18, 2016

a.notDeepEqual,
new Date(),
new Date(2000, 3, 14)),
'deepEqual(new Date(), new Date(2000, 3, 14))'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notDeepEqual ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yes, you are correct, fixed!

@targos
Copy link
Member

targos commented Aug 18, 2016

LGTM

2 similar comments
@claudiorodriguez
Copy link
Contributor

LGTM

@santigimeno
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Aug 18, 2016

@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 20, 2016
There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

PR-URL: nodejs#8156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this Aug 20, 2016
@Trott
Copy link
Member Author

Trott commented Aug 20, 2016

Landed in 294e300

evanlucas pushed a commit that referenced this pull request Aug 24, 2016
There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

PR-URL: #8156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

PR-URL: #8156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

PR-URL: #8156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
There are currently no tests for assert.notDeepEqual(). Add some minimal
tests.

PR-URL: #8156
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@Trott Trott deleted the notDeepEqual branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants