build: add missing files to zip and 7z packages #8069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages.
mscdex
added
build
| @@ -126,6 +126,8 @@ if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu | |||
|
|
|||
| call :getnodeversion || exit /b 1 | |||
|
|
|||
| if "%target%"=="Clean" rmdir /Q /S "%~dp0%config%\node-v%FULLVERSION%-win-%target_arch%" > nul 2> nul | |||
There was a problem hiding this comment.
On my box this deletes only Release\node-v7.0.0-win-x64, leaving other configurations
There was a problem hiding this comment.
clean will clear stuff under the selected configuration config (which defaults to Release unless debug is passed as an argument to vcbuild.bat). This is consistent with msbuild which only clears out the object files for the selected configuration with clean.
|
Added a comment about |
|
@orangemocha @joaocgreis can you take a look and comment. |
|
LGTM Note that the MSI installs the manifests in the system. Here, they will have to be installed manually by users. I think it's good to enable them to. |
|
LGTM |
|
LGTM, will land. |
mhdawson
pushed a commit
that referenced
this pull request
Aug 25, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: #8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
CI run was good, landed as 18017d6 |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: nodejs#8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: #8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
@richardlau should this be backported? |
|
@thealphanerd Yes, please |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: #8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: #8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man to the zip and 7z packages. PR-URL: #8069 Reviewed-By: James M Snell <[email protected]> Reviewed-By: joaocgreis - João Reis <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX)vcbuild test nosign package(Windows) passesAffected core subsystem(s)
build
Description of change
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages. These files are already being installed by the msi
installer (with default options).