Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add missing files to zip and 7z packages #8069

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Aug 11, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign package (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages. These files are already being installed by the msi
installer (with default options).

Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.
@mscdex mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Aug 12, 2016
@@ -126,6 +126,8 @@ if "%target%"=="Clean" rmdir /S /Q %~dp0deps\icu

call :getnodeversion || exit /b 1

if "%target%"=="Clean" rmdir /Q /S "%~dp0%config%\node-v%FULLVERSION%-win-%target_arch%" > nul 2> nul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my box this deletes only Release\node-v7.0.0-win-x64, leaving other configurations

Copy link
Member Author

@richardlau richardlau Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean will clear stuff under the selected configuration config (which defaults to Release unless debug is passed as an argument to vcbuild.bat). This is consistent with msbuild which only clears out the object files for the selected configuration with clean.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then LGTM

@bzoz
Copy link
Contributor

bzoz commented Aug 12, 2016

Added a comment about Clean, otherwise LGTM

@mhdawson
Copy link
Member

@orangemocha @joaocgreis can you take a look and comment.

@joaocgreis
Copy link
Member

LGTM

Note that the MSI installs the manifests in the system. Here, they will have to be installed manually by users. I think it's good to enable them to.

@jasnell
Copy link
Member

jasnell commented Aug 17, 2016

LGTM

@mhdawson
Copy link
Member

LGTM, will land.

@mhdawson mhdawson self-assigned this Aug 25, 2016
@mhdawson
Copy link
Member

mhdawson pushed a commit that referenced this pull request Aug 25, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

CI run was good, landed as 18017d6

@mhdawson mhdawson closed this Aug 25, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: nodejs#8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins
Copy link
Contributor

@richardlau should this be backported?

@richardlau
Copy link
Member Author

@thealphanerd Yes, please

MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: joaocgreis - João Reis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants