Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct crypto encoding information (v4.x) #7799

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of binary.

Ref: #5500
Fixes: #7712

The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: nodejs#5500
Fixes: nodejs#7712
@addaleax addaleax added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. v4.x labels Jul 19, 2016
@addaleax addaleax changed the title doc: correct crypto encoding information doc: correct crypto encoding information (v4.x) Jul 19, 2016
@claudiorodriguez
Copy link
Contributor

LGTM

@bnoordhuis
Copy link
Member

LGTM. Perhaps the documentation could be explicit about the fact that the default encoding changed in v6?

Aside: 'enforced' is a bit of an odd choice of words.

@addaleax
Copy link
Member Author

I’ve updated with “implied” substituted where “enforced” is currently being used. And +1 to being explicit about the change in v6, but that should probably go into a different PR against master.

@MylesBorins
Copy link
Contributor

@addaleax is this important enough to be rolled into v4.5.0 or could it wait for the next patch release?

@addaleax
Copy link
Member Author

@thealphanerd uff… doesn’t really matter? It can wait, but it’s a only a correction in the docs.

@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

LGTM

jasnell pushed a commit that referenced this pull request Aug 1, 2016
The default encoding for crypto methods was changed in v6.0.0,
with v4.x keeping a default of `binary`.

Ref: #5500
Fixes: #7712
PR-URL: #7799
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 1, 2016

Landed in d771d5e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants