deps: backport 22c5e46 from V8 #7584

MylesBorins · 2016-07-07T14:39:32Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

This removes the diagnostic code for the issue described in
https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue
is private, probably due to the fact that it contains information about
a security vulnerability.

The original issue was fixed in V8 by
https://codereview.chromium.org/1286343004, which was integrated into
node v4.x with c431725, so there's no
need for the corresponding diagnostic code anymore.

Original commit message:

[heap] Remove debugging code of crbug/454297.

BUG=

Review URL: https://codereview.chromium.org/1420253002

Cr-Commit-Position: refs/heads/master@{#31523}

Fixes #7574.

MylesBorins · 2016-07-07T14:40:19Z

v8 test: https://ci.nodejs.org/job/node-test-commit-v8-linux/181/

MylesBorins · 2016-07-07T14:40:55Z

/cc @nodejs/lts @nodejs/v8 @misterdjules

bnoordhuis · 2016-07-07T14:52:12Z

You need to bump the patch level in v8-version.h.

misterdjules · 2016-07-07T15:12:50Z

It's still not clear to me why the diagnostic code was left, and why it still makes some node programs crash when the bug fix for the associated issue is present in the code base. I wouldn't want to merge this change before these two questions are answered.

misterdjules · 2016-07-07T18:28:10Z

It's still not clear to me why the diagnostic code was left, and why it still makes some node programs crash when the bug fix for the associated issue is present in the code base.

The reason why the diagnostic code crashes on some OSes (like SmartOS) while the fix for the original code is in the code base is now clear per #7574 (comment), so I'm OK with merging this, as long as @bnoordhuis' comments are addressed.

misterdjules · 2016-07-07T18:28:53Z

@bnoordhuis

You need to bump the patch level in v8-version.h.

Wouldn't we end up with a V8 patch level that doesn't exist in any V8 release line?

bnoordhuis · 2016-07-07T18:54:59Z

Yes, but that's alright for 4.5 because we're the de facto upstream.

anandsuresh · 2016-07-07T19:58:42Z

Any ideas when this would be merged and released for 4.5?

misterdjules · 2016-07-07T21:01:44Z

@thealphanerd Do you mind updating the patch level? Otherwise I'd need to create another PR from another branch.

misterdjules · 2016-07-07T22:42:37Z

@thealphanerd Thanks for bumping the patch level!

MylesBorins · 2016-07-07T22:43:21Z

bumped patch level. Completely at a loss as to why I couldn't find the file at first. Will make sure to bump that in the future

I'm going to mention in nodejs/Release#111 that we should perhaps look at having an official LTS 4.5 release.

/cc @natorion

MylesBorins · 2016-07-08T14:55:03Z

can I get some LGTM's on this please 😄

targos · 2016-07-08T15:01:41Z

LGTM

bnoordhuis · 2016-07-08T15:21:16Z

LGTM

ofrobots · 2016-07-11T13:20:35Z

LGTM.

This removes the diagnostic code for the issue described in https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue is private, probably due to the fact that it contains information about a security vulnerability. The original issue was fixed in V8 by https://codereview.chromium.org/1286343004, which was integrated into node v4.x with c431725, so there's no need for the corresponding diagnostic code anymore. Original commit message: [heap] Remove debugging code of crbug/454297. BUG= Review URL: https://codereview.chromium.org/1420253002 Cr-Commit-Position: refs/heads/master@{nodejs#31523} PR-URL: nodejs#7584 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>

MylesBorins · 2016-07-11T17:00:55Z

thank everyone landed in 4184cb0

This removes the diagnostic code for the issue described in https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue is private, probably due to the fact that it contains information about a security vulnerability. The original issue was fixed in V8 by https://codereview.chromium.org/1286343004, which was integrated into node v4.x with c431725, so there's no need for the corresponding diagnostic code anymore. Original commit message: [heap] Remove debugging code of crbug/454297. BUG= Review URL: https://codereview.chromium.org/1420253002 Cr-Commit-Position: refs/heads/master@{#31523} PR-URL: #7584 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>

Original commit message: deps backport 22c5e46 from V8 This removes the diagnostic code for the issue described in https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue is private, probably due to the fact that it contains information about a security vulnerability. The original issue was fixed in V8 by https://codereview.chromium.org/1286343004, which was integrated into node v4.x with c431725, so there's no need for the corresponding diagnostic code anymore. Original commit message: [heap] Remove debugging code of crbug/454297. BUG= Review URL: https://codereview.chromium.org/1420253002 Cr-Commit-Position: refs/heads/master@{#31523} PR-URL: nodejs/node#7584 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>

This removes the diagnostic code for the issue described in https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue is private, probably due to the fact that it contains information about a security vulnerability. The original issue was fixed in V8 by https://codereview.chromium.org/1286343004, which was integrated into node v4.x with c431725, so there's no need for the corresponding diagnostic code anymore. Original commit message: [heap] Remove debugging code of crbug/454297. BUG= Review URL: https://codereview.chromium.org/1420253002 Cr-Commit-Position: refs/heads/master@{#31523} PR-URL: #7584 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>

Original commit message: deps backport 22c5e46 from V8 This removes the diagnostic code for the issue described in https://bugs.chromium.org/p/chromium/issues/detail?id=454297. That issue is private, probably due to the fact that it contains information about a security vulnerability. The original issue was fixed in V8 by https://codereview.chromium.org/1286343004, which was integrated into node v4.x with c431725, so there's no need for the corresponding diagnostic code anymore. Original commit message: [heap] Remove debugging code of crbug/454297. BUG= Review URL: https://codereview.chromium.org/1420253002 Cr-Commit-Position: refs/heads/master@{#31523} PR-URL: nodejs/node#7584 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>

MylesBorins added v8 engine Issues and PRs related to the V8 dependency. v4.x labels Jul 7, 2016

MylesBorins force-pushed the backport/22c5e46 branch from 6679e61 to 7fb0bc5 Compare July 7, 2016 22:40

misterdjules added the lts-watch-v4.x label Jul 7, 2016

MylesBorins mentioned this pull request Jul 7, 2016

Managing floating V8 patches nodejs/Release#111

Closed

MylesBorins force-pushed the backport/22c5e46 branch from 7fb0bc5 to 4184cb0 Compare July 11, 2016 16:55

MylesBorins merged commit 4184cb0 into nodejs:v4.x-staging Jul 11, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jul 11, 2016

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

misterdjules mentioned this pull request Sep 15, 2016

Diagnostic code for fixed bug still present in v4.x's V8 #7574

Closed

MylesBorins deleted the backport/22c5e46 branch October 11, 2016 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: backport 22c5e46 from V8 #7584

deps: backport 22c5e46 from V8 #7584

MylesBorins commented Jul 7, 2016 •

edited

Loading

MylesBorins commented Jul 7, 2016 •

edited

Loading

MylesBorins commented Jul 7, 2016

bnoordhuis commented Jul 7, 2016

misterdjules commented Jul 7, 2016 •

edited

Loading

misterdjules commented Jul 7, 2016

misterdjules commented Jul 7, 2016

bnoordhuis commented Jul 7, 2016

anandsuresh commented Jul 7, 2016

misterdjules commented Jul 7, 2016

misterdjules commented Jul 7, 2016

MylesBorins commented Jul 7, 2016

MylesBorins commented Jul 8, 2016

targos commented Jul 8, 2016

bnoordhuis commented Jul 8, 2016

ofrobots commented Jul 11, 2016

MylesBorins commented Jul 11, 2016

deps: backport 22c5e46 from V8 #7584

deps: backport 22c5e46 from V8 #7584

Conversation

MylesBorins commented Jul 7, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

MylesBorins commented Jul 7, 2016 • edited Loading

MylesBorins commented Jul 7, 2016

bnoordhuis commented Jul 7, 2016

misterdjules commented Jul 7, 2016 • edited Loading

misterdjules commented Jul 7, 2016

misterdjules commented Jul 7, 2016

bnoordhuis commented Jul 7, 2016

anandsuresh commented Jul 7, 2016

misterdjules commented Jul 7, 2016

misterdjules commented Jul 7, 2016

MylesBorins commented Jul 7, 2016

MylesBorins commented Jul 8, 2016

targos commented Jul 8, 2016

bnoordhuis commented Jul 8, 2016

ofrobots commented Jul 11, 2016

MylesBorins commented Jul 11, 2016

MylesBorins commented Jul 7, 2016 •

edited

Loading

MylesBorins commented Jul 7, 2016 •

edited

Loading

misterdjules commented Jul 7, 2016 •

edited

Loading