deps: remove extra field from v8::HeapStatistics #7526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `_malloced_memory` field from the `HeapStatistics` class to achieve full ABI compatibility with V8 5.0. Ref: nodejs#7016
addaleax
added
v8 engine
|
LGTM, I guess. Any chance V8 would accept this? |
|
Yeah, this should likely be pushed up stream first. |
|
@bnoordhuis +1 SGTM! |
|
Landed in 4c774e1 |
addaleax
added a commit
that referenced
this pull request
Jul 7, 2016
Remove the `_malloced_memory` field from the `HeapStatistics` class to achieve full ABI compatibility with V8 5.0. Ref: #7016 PR-URL: #7526 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
@addaleax Is this supposed to land on v6 but not v7? |
|
@addaleax Correct, but wouldn't we want this new field for V7? |
|
for v7 we will have a new version of V8. The process of upgrading V8 to a new major version cancels all patches that we apply to |
ofrobots
pushed a commit
to ofrobots/node
that referenced
this pull request
Aug 25, 2016
Remove the `_malloced_memory` field from the `HeapStatistics` class to achieve full ABI compatibility with V8 5.0. Ref: nodejs#7016 PR-URL: nodejs#7526 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps/v8
Description of change
Remove the
_malloced_memoryfield from theHeapStatisticsclass to achieve full ABI compatibility with V8 5.0 (as far as I can tell).This structure is probably not something used by addons anyway, since the information from that struct is already made available through Node’s
v8.getHeapStatistics(), but better safe than sorry.Ref: #7016 (comment) (and it would need to be landed in v6 together with #7016).
/cc @ofrobots @nodejs/v8