deps: fix V8 5.1 tests #7488
Closed
deps: fix V8 5.1 tests #7488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore whitespaces in *.golden files. They were lost when I landed the V8 5.1 update. Fixes: nodejs#7477
nodejs-github-bot
added
the
lib / src
targos
removed
the
lib / src
|
WOW. Whitespace causing this pain is pretty wonderful. ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/165/ |
|
😢 As mentioned in another thread recently, we should really consider landing deps changes without |
|
benchmark is green. I'm +1 on revisiting whitespace-fix for dependnecies... thoughts @nodejs/ctc? |
|
I think I agree. |
|
LGTM |
targos
added a commit
to targos/node
that referenced
this pull request
Jun 30, 2016
Restore whitespaces in *.golden files. They were lost when I landed the V8 5.1 update and are needed for the tests to pass. Fixes: nodejs#7477 PR-URL: nodejs#7488 Reviewed-By: Michael Dawson <[email protected]>
|
landed in dc17432 |
|
Please add the relevant label(s) for master-only commits. Thanks. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-v8passesAffected core subsystem(s)
v8
Description of change
Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.
Fixes: #7477