Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: undeprecate existsSync; use access instead of stat for performance #7455

Closed
wants to merge 3 commits into from
Closed

fs: undeprecate existsSync; use access instead of stat for performance #7455

wants to merge 3 commits into from

Commits on Aug 16, 2016

  1. fs: make existsSync faster by not throwing 

    The existing implementation throws ignored exceptions, which is slow.
The new implementation returns a simple boolean without throwing.
    @dfabulich
    dfabulich committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    b026c0e View commit details
    Browse the repository at this point in the history

  2. fs: make exists faster by using access 

    access is faster than stat, because we don't have to return the
actual stat results.
    @dfabulich
    dfabulich committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    19689e4 View commit details
    Browse the repository at this point in the history

  3. fs: undeprecate existsSync 

    There's no alternative method to use that doesn't throw an exception
when the file doesn't exist.
    @dfabulich
    dfabulich committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    d255e0f View commit details
    Browse the repository at this point in the history