deps: backport 7dfb5beeec from V8 upstream

[MylesBorins]

Checklist

• make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
• a test and/or benchmark is included
• the commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

This commit backports a fix to a JIT bug in V8.
After 100 or so comparisons typeof null ==="undefined" is returning
true instead of false.

Original commit message:

Fix 'typeof null' canonicalization in crankshaft

BUG=

Review URL: https://codereview.chromium.org/1912553002

Cr-Commit-Position: refs/heads/master@{#35699}

[MylesBorins]

ci: https://ci.nodejs.org/job/node-test-pull-request/3044/
v8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/141/

/cc @ofrobots @nodejs/v8

[indutny]

Any reason to rush it and not wait until it will be merged into V8 5.2?

[MylesBorins]

Based on the reddit thread it seemed like people were running into this problem in production. We can likely wait on it, but I wasn't sure how long it would take to prove out that the V8 5.2 update is non ABI breaking

[indutny]

@thealphanerd 👍 then.

[bnoordhuis]

@thealphanerd Can you request a back-port to 5.0 and 5.1 upstream? Then we can just upgrade wholesale.

[bnoordhuis]

Also, it looks like v6 is affected but v4 and v5 are not.

[MylesBorins]

@bnoordhuis more than happy to. What is the process for doing so?

[bnoordhuis]

@thealphanerd https://github.com/v8/v8/wiki/Merging%20&%20Patching

[MylesBorins]

I have opened a backport request in the chromium tracker

https://codereview.chromium.org/2087803004/

@ofrobots seems to imply that we should likely float for V8 5 until nodejs/Release#111 has been sorted

[ofrobots]

This got cherry-picked onto in V8 5.1 earlier today. As far as V8 5.0 is concerned, that branch is no longer getting tested, and there is no official process to merge changes into it, until nodejs/Release#111 gets to closure. /cc @natorion

Until then I think we should float this patch.

@thealphanerd instead if the reddit link, could you link to the upstream bug for this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=604033.

Otherwise this LGTM as long as V8 tests pass.

[bnoordhuis]

LGTM but I second Ali's comment about the reddit link.

[MylesBorins]

Link updated. In future I'll double check the chromium tracker first 😄

V8 tests passed, just waiting on a fresh run of the CI

[targos]

LGTM.
There is a nit in the commit message: s/B8/V8/

[MylesBorins]

thanks @targos I was doing s/v/V and accidentally s/v/B'd

¯_(ツ)_/¯

[MylesBorins]

landed in a84b0f2

[MylesBorins]

I've gone ahead and landed this on v6.x as c544213