Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: return valid file: urls fom url.format() #7234

Closed
wants to merge 3 commits into from
Closed

url: return valid file: urls fom url.format() #7234

wants to merge 3 commits into from

Commits on Jun 9, 2016

  1. url: return valid file: urls fom url.format() 

    `file:` URLs that do not start with `file://` are invalid. Browsers
convert `file:/etc/passwd` to `file:///etc/passwd`. This is also what
the docs indicate we are doing, but we're not.

Fixes: nodejs#3361
    @Trott
    Trott committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    4e8c661 View commit details
    Browse the repository at this point in the history

  2. squash: use string concatenation instead of template

    @Trott
    Trott committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    99f87da View commit details
    Browse the repository at this point in the history

  3. squash: startsWith() -> charCodeAt()

    @Trott
    Trott committed Jun 9, 2016
    Configuration menu
    Copy the full SHA
    4c9f18c View commit details
    Browse the repository at this point in the history