Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_wrap: pass uid to JS as double #7096

Merged
merged 1 commit into from
Jun 1, 2016
Merged

async_wrap: pass uid to JS as double #7096

merged 1 commit into from
Jun 1, 2016

Commits on Jun 1, 2016

  1. async_wrap: pass uid to JS as double 

    Passing the uid via v8::Integer::New() converts it to a uint32_t. Which
will trim the value early. Instead use v8::Number::New() to convert the
int64_t to a double so that JS can see the full 2^53 range of uid's.

PR-URL: nodejs#7096
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    f81f0c3 View commit details
    Browse the repository at this point in the history