Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for stream #7010

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for stream #7010

wants to merge 1 commit into from

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented May 27, 2016

Work in Progress, waiting for #6947

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for stream

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 27, 2016
@addaleax addaleax added wip Issues and PRs that are still a work in progress. stream Issues and PRs related to the stream subsystem. labels May 27, 2016
@addaleax
Copy link
Member

Hi again! I’ve added the in progress label to your PR so people know it’s not ready yet, but please ping us when you wish it to be removed or if you have any other questions. Thanks for doing this!

And by the very, generally very helpful tools for these kinds of things are the git log, the changelog files and checking the releases manually using tools like nvm or checking the distribution tarballs themselves (pre-iojs ones can be found in https://nodejs.org/dist/).

@jasnell
Copy link
Member

jasnell commented May 27, 2016

@addaleax ... might want to hold off just a bit on this until #6947 lands.

@addaleax
Copy link
Member

@jasnell sounds like a good idea, yeah.

@italoacasas it’s probably a good idea not to commit too much here until #6947 is through, because there will likely be merge conflicts otherwise – that should not keep you from gathering the information, though. :)

@italoacasas
Copy link
Contributor Author

Ok no problem. Let's hold this PR until #6947 is done.

@addaleax
Copy link
Member

Btw, #6947 has landed, so that should not stand in the way of this anymore.

@italoacasas
Copy link
Contributor Author

Cool, I start working on this tonight.

@italoacasas
Copy link
Contributor Author

#7287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants