test: check types for http request and response #7003
Conversation
bnoordhuis
added
http
|
New CI: https://ci.nodejs.org/job/node-test-pull-request/3113/ |
| const http = require('http'); | ||
|
|
||
| const host = common.localhostIPv4; | ||
| const port = common.PORT; |
There was a problem hiding this comment.
I believe we're moving away from using common.PORT... correct @Trott ?
There was a problem hiding this comment.
FWIW I'd say that is the plan.
There was a problem hiding this comment.
I wouldn't stop something from landing over it, but yes, I would say that there is a preference for server.listen(0) over server.listen(common.PORT) where possible.
There was a problem hiding this comment.
IMHO this should be a blocker for landing any PR, otherwise we could easily end up in the same situation again with cascading test failures if we start being lax about it.
There was a problem hiding this comment.
IMHO this should be a blocker for landing any PR, otherwise we could easily end up in the same situation again with cascading test failures if we start being lax about it.
That's reasonable (with the note that there are currently situations that require common.PORT or something like it, but you know that and no doubt mean to exclude those situations).
|
LGTM if CI is green |
bnoordhuis
force-pushed
the
test-http-maps
branch
from
e6368c2
to
f5f1729
Compare
|
Dropped usage of |
|
Le sigh, one more fix-up for the Windows buildbots. They didn't like omitting the bind address. |
|
CI is green. LGTM |
|
LGTM |
Add a basic regression test that checks if the map for IncomingMessage and OutgoingMessage objects is stable over time. The test is not exhaustive in that it doesn't try to establish whether the transition path is the same on every request, it just checks that objects in their final states have the same map. To be investigated why the first (and only the first) ServerRequest object ends up with a deprecated map, regardless of the number of iterations. PR-URL: nodejs#7003 Refs: nodejs#6294 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
test-http-maps
branch
from
ced421a
to
dac16d8
Compare
Add a basic regression test that checks if the map for IncomingMessage and OutgoingMessage objects is stable over time. The test is not exhaustive in that it doesn't try to establish whether the transition path is the same on every request, it just checks that objects in their final states have the same map. To be investigated why the first (and only the first) ServerRequest object ends up with a deprecated map, regardless of the number of iterations. PR-URL: #7003 Refs: #6294 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add a basic regression test that checks if the map for IncomingMessage and OutgoingMessage objects is stable over time. The test is not exhaustive in that it doesn't try to establish whether the transition path is the same on every request, it just checks that objects in their final states have the same map. To be investigated why the first (and only the first) ServerRequest object ends up with a deprecated map, regardless of the number of iterations. PR-URL: #7003 Refs: #6294 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add a basic regression test that checks if the map for IncomingMessage and OutgoingMessage objects is stable over time. The test is not exhaustive in that it doesn't try to establish whether the transition path is the same on every request, it just checks that objects in their final states have the same map. To be investigated why the first (and only the first) ServerRequest object ends up with a deprecated map, regardless of the number of iterations. PR-URL: #7003 Refs: #6294 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
I'm backing this out of v4.x as it was causing failures on windows Will dig more into this another time |
Add a basic regression test that checks if the map for IncomingMessage
and OutgoingMessage objects is stable over time.
The test is not exhaustive in that it doesn't try to establish whether
the transition path is the same on every request, it just checks that
objects in their final states have the same map.
To be investigated why the first (and only the first) ServerRequest
object ends up with a deprecated map, regardless of the number of
iterations.
Refs: #6294
CI: https://ci.nodejs.org/job/node-test-pull-request/2810/