-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add @othiym23 to list of collaborators #6945
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM! |
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: #6945 Reviewed-By: Chris Dickinson <[email protected]>
othiym23
force-pushed
the
othiym23-belated-collaborator-addition
branch
from
May 24, 2016 03:49
a768233
to
34d1932
Compare
Landed as 34d1932. Thanks to @chrisdickinson for the speedy rubberstamp review. |
🎉 |
@othiym23 Glad the paper work(!) is taken care of :-) I am removing the branch. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: nodejs#6945 Reviewed-By: Chris Dickinson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: #6945 Reviewed-By: Chris Dickinson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 3, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: #6945 Reviewed-By: Chris Dickinson <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: #6945 Reviewed-By: Chris Dickinson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April 2015. I thought I'd added myself to the list of collaborators, but apparently hadn't. I was onboarded by @chrisdickinson as part of the second or third group of collaborators added to the project. PR-URL: #6945 Reviewed-By: Chris Dickinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
I could have sworn that I did this when @chrisdickinson onboarded me a year ago, but I would be swearing falsely. Thanks to the heads up from @rvagg and @chrisdickinson that this needed to be done.
r: @chrisdickinson