Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add @othiym23 to list of collaborators #6945

Merged
merged 1 commit into from
May 24, 2016

Conversation

othiym23
Copy link
Contributor

@othiym23 othiym23 commented May 24, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

I could have sworn that I did this when @chrisdickinson onboarded me a year ago, but I would be swearing falsely. Thanks to the heads up from @rvagg and @chrisdickinson that this needed to be done.

r: @chrisdickinson

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 24, 2016
@chrisdickinson
Copy link
Contributor

LGTM!

Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: #6945
Reviewed-By: Chris Dickinson <[email protected]>
@othiym23 othiym23 force-pushed the othiym23-belated-collaborator-addition branch from a768233 to 34d1932 Compare May 24, 2016 03:49
@othiym23 othiym23 merged commit 34d1932 into master May 24, 2016
@othiym23
Copy link
Contributor Author

Landed as 34d1932. Thanks to @chrisdickinson for the speedy rubberstamp review.

@MylesBorins
Copy link
Contributor

🎉

@thefourtheye thefourtheye deleted the othiym23-belated-collaborator-addition branch May 24, 2016 06:31
@thefourtheye
Copy link
Contributor

@othiym23 Glad the paper work(!) is taken care of :-) I am removing the branch.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: nodejs#6945
Reviewed-By: Chris Dickinson <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: #6945
Reviewed-By: Chris Dickinson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: #6945
Reviewed-By: Chris Dickinson <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: #6945
Reviewed-By: Chris Dickinson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Forrest Norvell (that's me!) has been a collaborator since roughly April
2015. I thought I'd added myself to the list of collaborators, but
apparently hadn't. I was onboarded by @chrisdickinson as part of the
second or third group of collaborators added to the project.

PR-URL: #6945
Reviewed-By: Chris Dickinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants