Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android fixes #6733

Closed
wants to merge 2 commits into from
Closed

Android fixes #6733

wants to merge 2 commits into from

Commits on May 13, 2016

  1. build: fix target_arch variables from GYP_DEFINES 

    In case of x86 arch, the target_arch variables passed through
GYP_DEFINES is also x86. But, this value is not recognized by gyp files,
so we need to pass ia32 instead. For x86 arch, we need to pass the value
of DEST_CPU, which is ia32.

Signed-off-by: Robert Chiras <[email protected]>
    @robertchiras
    robertchiras committed May 13, 2016
    Configuration menu
    Copy the full SHA
    a0b396c View commit details
    Browse the repository at this point in the history

  2. child_process: verify buffer when writing to strerr 

    In execSync/execFileSync commands, we better verify the stderr buffer
from ret. In case of other exceptions thrown by spawnSync this buffer
might be null. If we don't check it and try to write it to process.stderr
we will end up throwing an irrelevant exception from Socket.write,
masking the initial exception which might show what is actually wrong
with spawnSync. Such an exception was hidden, when running this test on
Android. The exception was about '/bin/sh' not found, since in Android,
sh can be found in '/system/bin/sh'.

Signed-off-by: Robert Chiras <[email protected]>
    @robertchiras
    robertchiras committed May 13, 2016
    Configuration menu
    Copy the full SHA
    4670022 View commit details
    Browse the repository at this point in the history