Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path: fix basename() regressions #6590

Merged
merged 3 commits into from
May 18, 2016
Merged

path: fix basename() regressions #6590

merged 3 commits into from
May 18, 2016

Commits on May 18, 2016

  1. path: fix basename() regressions 

    This commit fixes a regression in basename() for the case when a
supplied extension name completely matches the resulting basename.

Fixes: nodejs#6587
PR-URL: nodejs#6590
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
    @mscdex
    mscdex committed May 18, 2016
    Configuration menu
    Copy the full SHA
    dfaa9c9 View commit details
    Browse the repository at this point in the history

  2. test: remove duplicate path tests 

    The TypeError checks are already done later on in the test file
for all path functions.

PR-URL: nodejs#6590
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
    @mscdex
    mscdex committed May 18, 2016
    Configuration menu
    Copy the full SHA
    7d40412 View commit details
    Browse the repository at this point in the history

  3. test: add more path.basename() tests 

    PR-URL: nodejs#6590
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
    @mscdex
    mscdex committed May 18, 2016
    Configuration menu
    Copy the full SHA
    27549f6 View commit details
    Browse the repository at this point in the history