Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,cluster: fix the lint of an example #6516

Closed
wants to merge 2 commits into from

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented May 2, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
  • cluster
Description of change

Just fix the example at https://nodejs.org/dist/latest-v6.x/docs/api/cluster.html, which doesn't follow the coding style.

By the way, how about moving example codes outside to separate files so that we can lint them in our build system.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 2, 2016
@yorkie
Copy link
Contributor Author

yorkie commented May 2, 2016

As for this is only fix to docs, so we don't have a test case for that :-)

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label May 2, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 2, 2016

LGTM

@Fishrock123
Copy link
Contributor

lgtm

@jasnell
Copy link
Member

jasnell commented May 2, 2016

LGTM

@silverwind
Copy link
Contributor

By the way, how about moving example codes outside to separate files so that we can lint them in our build system.

No need to, we can lint them in place. #5053 is set up to do that, but it's kind of dead right now.

@yorkie
Copy link
Contributor Author

yorkie commented May 3, 2016

Wait for CI?

@jasnell
Copy link
Member

jasnell commented May 3, 2016

There's really no CI for docs. Will get this landed shortly. Thanks @yorkie !

@yorkie
Copy link
Contributor Author

yorkie commented May 3, 2016

Ok, just make sure if this one is in your plan, that's my pleasure :-)

jasnell pushed a commit that referenced this pull request May 3, 2016
PR-URL: #6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented May 3, 2016

Landed in 8637c27. Thank you @yorkie !

@jasnell jasnell closed this May 3, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
PR-URL: #6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@yorkie yorkie deleted the fix/doc-example branch May 4, 2016 02:48
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
PR-URL: nodejs#6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants