build: don't compile with -B #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
New |
|
LGTM |
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: nodejs#6393 Reviewed-By: Anna Henningsen <[email protected]>
bnoordhuis
force-pushed
the
linux_use_bundled_gold
branch
from
27ff94c
to
3cdb506
Compare
|
Thanks, Anna. Release people: this can land in the stable branches but it's a fairly trivial change so feel free to leave it out. |
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
This was referenced May 4, 2016
See #6603, apparently it's needed by at least some people that build from source. |
|
Release people: #6650 depends on this PR. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
May 10, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: nodejs#6603 PR-URL: nodejs#6650 Refs: nodejs#6393 Reviewed-By: Anna Henningsen <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
|
@bnoordhuis is there value in backporting this or should we just skip it for LTS because of the regression (even though it was patched) |
|
Thanks @bnoordhuis |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: #6393 Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is not very reliable. I'm positive it worked when commit 3cdb506 ("build: don't compile with -B") was merged but subsequent updates appear to have broken it again. Take the nuclear option and disable them from `tools/node_gyp.py`. Fixes: #6603 PR-URL: #6650 Refs: #6393 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off the custom toolchain, we don't bundle ld.gold. It's not that
useful anyway because it uses a fixed path. For people that do use a
custom toolchain, there is the GCC_EXEC_PREFIX environment variable.
CI: https://ci.nodejs.org/job/node-test-pull-request/2397/