deps: upgrade to V8 4.9.385.35 #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
PR-URL: nodejs#6077 Reviewed-By: Trevor Norris <[email protected]>
We don't link with `--gc-sections` because it's unreliable with some toolchains, so all these flags do is make the compiler generate slightly worse code. Drop them. Refs: nodejs#6056 PR-URL: nodejs#6077 Reviewed-By: Trevor Norris <[email protected]>
|
@bnoordhuis safe to assume this does not make sense for lts? |
|
71544c5 could be cherry-picked but it's not critical. |
|
@bnoordhuis this is not landing cleanly on |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
We don't link with `--gc-sections` because it's unreliable with some toolchains, so all these flags do is make the compiler generate slightly worse code. Drop them. Refs: #6056 PR-URL: #6077 Reviewed-By: Trevor Norris <[email protected]>
|
@thealphanerd When you say 'this', do you mean the V8 upgrade or the other commit? |
|
The v8 upgrade. The other commit landed without problem |
|
The V8 upgrade shouldn't go into v4 or v5. There are perhaps some individual fixes we could cherry-pick. |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
We don't link with `--gc-sections` because it's unreliable with some toolchains, so all these flags do is make the compiler generate slightly worse code. Drop them. Refs: #6056 PR-URL: #6077 Reviewed-By: Trevor Norris <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
We don't link with `--gc-sections` because it's unreliable with some toolchains, so all these flags do is make the compiler generate slightly worse code. Drop them. Refs: #6056 PR-URL: #6077 Reviewed-By: Trevor Norris <[email protected]>
|
@bnoordhuis if you think any parts of this should be backported to v4.x-staging could you please open a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@nodejs/v8
I threw in the
build: remove -f{data,function}-sections flagscommit because otherwise I'd have to rebuild twice. :-) See #6056 for background.CI: https://ci.nodejs.org/job/node-test-pull-request/2173/